Review Request 103692: replace mkdtemp for more portabilitiy

Patrick Spendrin ps_ml at gmx.de
Tue Jan 6 08:06:07 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/103692/
-----------------------------------------------------------

(Updated Jan. 6, 2015, 8:06 a.m.)


Review request for Gwenview, David Faure and Lukáš Tinkl.


Changes
-------

Lukas (new gwenview maintainer) - can you check this? The patch looks good to me, but I don't know how to test it. Of course in the frameworks branch, one can use my QTemporaryDir instead :-)


Repository: gwenview


Description
-------

since mkdtemp is not portable, I want to replace the code in question with the usage of KTempDir.


Diffs
-----

  importer/fileutils.cpp 2aa18b4 

Diff: https://git.reviewboard.kde.org/r/103692/diff/


Testing
-------

it builds well. Since I have no idea how that code is used, I hope you can give me some hints?


Thanks,

Patrick Spendrin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20150106/93379af0/attachment.html>


More information about the Gwenview-devel mailing list