Review Request 126437: Convert Profile away from the deprecated KSharedPtr
Shlomi Fish
shlomif at iglu.org.il
Sun Dec 20 20:33:49 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126437/
-----------------------------------------------------------
Review request for Gwenview.
Repository: gwenview
Description
-------
This converts Profile away from KSharedPtr which is deprecated in KF5. It eliminates some warnings. There is another instance of KSharedPtr in gwenview which I have had more difficulty converting.
Diffs
-----
lib/cms/cmsprofile.h 17cee19
tests/auto/cmsprofiletest.cpp f59c931
Diff: https://git.reviewboard.kde.org/r/126437/diff/
Testing
-------
I ran ./app/gwenview and everything mostly seems fine. I discovered a small bug in gwenview in the process but it seems to be in
the gwenview from Mageia as well.
Thanks,
Shlomi Fish
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20151220/7b524a6b/attachment.html>
More information about the Gwenview-devel
mailing list