Review Request 121140: Make Baloo detection and usage more subtle

Hrvoje Senjan hrvoje.senjan at gmail.com
Sun Nov 16 17:42:12 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121140/
-----------------------------------------------------------

(Updated Nov. 16, 2014, 6:42 p.m.)


Review request for Gwenview, David Edmundson, Lukáš Tinkl, and Vishesh Handa.


Repository: gwenview


Description
-------

at the moment we have slightly messy situation.
there is baloo/5.1, and baloo master. we know gwenview will not build with < 5.1.90, that is master.
also resolved the old problem when user would select baloo backend, but it wasn't found, thus the build would fail in the middle.


Diffs
-----

  CMakeLists.txt 928cbb1 
  lib/CMakeLists.txt ec64b24 

Diff: https://git.reviewboard.kde.org/r/121140/diff/


Testing (updated)
-------

inspected config-gwenview.h after passing various options (and locally raising required baloo version to 5.1.91)


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20141116/e56247a4/attachment.html>


More information about the Gwenview-devel mailing list