Review Request 121089: Replace the 'Recent URLs' tab with a 'Recent Files' one, which shows the same files as the recently opened menu item does.
Lukáš Tinkl
lukas at kde.org
Thu Nov 13 13:42:52 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121089/#review70324
-----------------------------------------------------------
app/mainwindow.cpp
<https://git.reviewboard.kde.org/r/121089/#comment49193>
const QUrl & url
lib/recentfilesmodel.cpp
<https://git.reviewboard.kde.org/r/121089/#comment49192>
Why create another QUrl variable here?
- Lukáš Tinkl
On Lis. 10, 2014, 9:31 dop., Tomas Mecir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121089/
> -----------------------------------------------------------
>
> (Updated Lis. 10, 2014, 9:31 dop.)
>
>
> Review request for Gwenview.
>
>
> Repository: gwenview
>
>
> Description
> -------
>
> This implements the Recent Files tab - motivation as per 331011 in bugzilla.
>
> First time I'm using the reviewboard, hopefully I haven't messed anything up :)
>
> BUG: 331011
>
>
> Diffs
> -----
>
> app/startmainpage.ui f85e738ad4cbedf7def1546e58173a45176e9434
> lib/CMakeLists.txt dc4933707b8db89f96b5b8528e747cc935855126
> lib/recentfilesmodel.h PRE-CREATION
> lib/recentfilesmodel.cpp PRE-CREATION
> app/gvcore.h 0f31f4de322254b5ea34628115c8e3a6f65b0d71
> app/gvcore.cpp 45eed93db39a0209844dc2f73a85d2de8e0bb136
> app/mainwindow.cpp 925e97cea5116dcb3330407fa075e077bf3d5e8b
> app/startmainpage.cpp eddc5cc5ca87282d5acd6cbefafc23a223cf31c3
>
> Diff: https://git.reviewboard.kde.org/r/121089/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomas Mecir
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20141113/f53a7735/attachment.html>
More information about the Gwenview-devel
mailing list