Review Request 115595: Enhancing zoom feature in Gwenview

[Aurélien Gâteau]

> On Feb. 12, 2014, 10:16 a.m., Commit Hook wrote:
> > This review has been submitted with commit 9d6f5c5e67644e9ae717500420be064ef9562070 by Aurélien Gâteau on behalf of Abhinav Gangwar to branch master.

Just committed your work, thanks a lot for your contribution!


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115595/#review49634
-----------------------------------------------------------


On Feb. 12, 2014, 10:16 a.m., Abhinav Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115595/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 10:16 a.m.)
> 
> 
> Review request for Gwenview and Aurélien Gâteau.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> The patch I designed will let Gwenview save the zoom configuration of current image, whenever the user switches to other image. Now if the other image has not been viewed before ( means no saved zoom configuration exists for this image), open it with the current zoom levels set by ZoomLock value (If ZoomLock is not enabled) or with its default size(if ZoomLock is not enabled). Otherwise display the image with its saved zoom configurations. After the Gwenview session ends, it will flush all these zoom configurations.
> 
>        The currently implemented ZoomLock feature allows to view all the images with same zoom level that has been set by user. Now, if a user switches to other image(say im2) from current image(say im1) and zoom it (to compare or some other purpose) with a different zoom level, he is gonna lost the previous image's(im1) zoom levels using which he wanted to compare the other image(im2). The user may need different zoom levels for different images to compare them. So, using the zoomlock feature, user still needs to change zoom levels again and again for images( becomes tedious for large number of images).
> 
> 
> Diffs
> -----
> 
>   app/viewmainpage.cpp b40b622 
>   lib/documentview/documentviewcontainer.h a4ef4a7 
>   lib/documentview/documentviewcontainer.cpp 475e7a8 
> 
> Diff: https://git.reviewboard.kde.org/r/115595/diff/
> 
> 
> Testing
> -------
> 
> I tested the patch on my system and it produced expected results.
> 
> 
> Thanks,
> 
> Abhinav Gangwar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20140212/b13058f6/attachment.html>