Review Request 112061: Move code to check next image is selected after removal to ContextManager

Aurélien Gâteau agateau at kde.org
Tue Sep 17 12:09:23 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112061/
-----------------------------------------------------------

Status
------

This change has been marked as submitted.


Review request for Gwenview.


Description
-------

This is necessary after this fix to KLinkItemSelectionModel [1]. Without this change Gwenview does not automatically advance to the next image when current image is removed.

It makes more sense anyway since there are multiple instances of ThumbnailView using the same model (or a proxy of it). Right now when a row of the model is removed every ThumbnailView instance checks the status of the current index. With this change, the check is done by the ContextManager, which exists only once.

[1]: https://git.reviewboard.kde.org/r/111953/


Diffs
-----

  app/contextmanager.h bb38079 
  app/contextmanager.cpp 85b3186 
  app/mainwindow.cpp de2d9ad 
  lib/thumbnailview/thumbnailview.cpp 0d148da 

Diff: http://git.reviewboard.kde.org/r/112061/diff/


Testing
-------

Removed images within a list, got correctly moved to the next one.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20130917/abea0267/attachment.html>


More information about the Gwenview-devel mailing list