Review Request 113397: RAW preview in gwenview

[Martin Kyral]

> On Oct. 23, 2013, 1:20 p.m., Aurélien Gâteau wrote:
> > lib/thumbnailprovider/thumbnailgenerator.cpp, line 62
> > <http://git.reviewboard.kde.org/r/113397/diff/1/?file=205135#file205135line62>
> >
> >     Why is this needed?
> 
> Martin Kyral wrote:
>     the bytearray containing format hint seems to be mandatory:
>     
>     (snip from qimagereader.h)
>         explicit QImageReader(QIODevice *device, const QByteArray &format = QByteArray());
>         explicit QImageReader(const QString &fileName, const QByteArray &format = QByteArray());
> 
> Martin Kyral wrote:
>     Maybe I missed the point - I copied the code from loadingdocumentimpl.cpp thinking that obtaining the file type via QImageReader is better/more reliable than just taking the file extension.
> 
> Martin Kyral wrote:
>     Hm, bad memory :-/ I realized that the QImageReader stuff was there w/o the format hint. Deleting the line. Sorry for confusing comments...

In the end the format hint is necessary. Without it, QImageReader considers raw files to be tiff and processing fails (the raw code block is not entered).


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113397/#review42211
-----------------------------------------------------------


On Oct. 25, 2013, 9:47 a.m., Martin Kyral wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113397/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2013, 9:47 a.m.)
> 
> 
> Review request for Gwenview and Aurélien Gâteau.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> This is a review of patch enabling raw support in gwenview. It uses KDcraw to extract the embedded jpeg preview (most of the raw formats contain it for the purposes of quick viewing the photos on the camera display) so it is fast, implementing was quite easy and theoretically it enables gwenview to support everything dcraw supports (practically we need to test more formats). The patch does not perform demosaicing and I don't think it shall - digikam, darktable or rawtherapee are much more suited for developing the 'digital negatives'.
> 
> The patch fixes BZ#158788
> 
> The patch enables support for Nikon NEF and NRW formats, Canon's CR2, Pentax PEF, Sony ARW and Adobe DNG. If you want to try another format, just adding it's MIME type to the list in lib/mimetypeutils.cpp shall be enough.
> 
> The patch as is contains just the basic functionality (generating proper thumbnails and viewing the raw images incl. EXIF metadata), but it is well usable. However, there is still a lot of stuff to do (see the commit message in the patch) so I'd appreciate any help.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4dafb7e 
>   lib/CMakeLists.txt c6ffe14 
>   lib/document/loadingdocumentimpl.cpp fbad8ff 
>   lib/glibraw.h PRE-CREATION 
>   lib/glibraw.cpp PRE-CREATION 
>   lib/gwenviewconfig.kcfg 231fd5e 
>   lib/mimetypeutils.cpp 546346f 
>   lib/thumbnailprovider/thumbnailgenerator.cpp 8b98904 
> 
> Diff: http://git.reviewboard.kde.org/r/113397/diff/
> 
> 
> Testing
> -------
> 
> Tested on some sample raw files taken from the camera reviews on http://www.photographyblog.com/ and bunch of my own photos. Nikon (tried D50, D70s, D90, D800 and Coolpix P7000), Canon (tried 7D, 5D Mark3 and 6D) and Pentax (K-X, K30) have the preview full-res, while Sony raw files (A900, A850, A58, Nex 3, Nex 6) have only 1616x1050.
> 
> 
> Thanks,
> 
> Martin Kyral
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20131029/be935517/attachment-0001.html>