Review Request 113397: RAW preview in gwenview

[Martin Kyral]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113397/
-----------------------------------------------------------

(Updated Nov. 11, 2013, 3:27 p.m.)


Review request for Gwenview and Aurélien Gâteau.


Repository: gwenview


Description (updated)
-------

This is a review of patch enabling raw support in gwenview. It uses KDcraw to extract the embedded jpeg preview (most of the raw formats contain it for the purposes of quick viewing the photos on the camera display) or loads half-scaled preview (otherwise) so it is fast, implementing was quite easy and theoretically it enables gwenview to support everything dcraw supports (I haven't found a raw file that gwenview doesn't show with this patch). The patch does not perform full demosaicing nor any tweaks (set white balance or so) and I don't think it shall - digikam, darktable or rawtherapee are much more suited for developing the 'digital negatives'.

The patch fixes BZ#158788

The patch enables support for Nikon NEF and NRW formats, Canon's CR2 and CRW, Pentax PEF, Sony ARW, Fuji RAF, Olympus ORF, Minolta MRW, Panasonic RW2, Samsung SRW and Adobe DNG. If you want to try another format, just adding it's MIME type to the list in lib/mimetypeutils.cpp shall be enough.

The patch is feature-complete (generating proper thumbnails and viewing the raw images incl. EXIF metadata) and well usable.

There are some stuff to do (directory thumbnails and thumbnail in the file - properties dialog in particular), but these things are out of gwenview sources. I'll try to find out the proper place to place the fix (it seems that the candidates are kdelibs, kipi plugins or digikam).


Diffs
-----

  lib/document/loadingdocumentimpl.cpp fbad8ff 
  lib/CMakeLists.txt c6ffe14 
  CMakeLists.txt 4dafb7e 
  lib/gwenviewconfig.kcfg 231fd5e 
  lib/mimetypeutils.cpp 546346f 
  lib/thumbnailprovider/thumbnailgenerator.cpp 8b98904 

Diff: http://git.reviewboard.kde.org/r/113397/diff/


Testing (updated)
-------

Tested on some sample raw files taken from the camera reviews on http://www.photographyblog.com/ and bunch of my own photos. I have tried files of every single format to be supported (for DNG I tested on files taken by cameras from several vendors incl. Pentax, Leica and Nokia).


Thanks,

Martin Kyral

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20131111/fda2010d/attachment.html>