Review Request 113397: RAW preview in gwenview

[Martin Kyral]

> On Nov. 8, 2013, 3:31 p.m., Aurélien Gâteau wrote:
> > So, I finally tried to apply the patch. Good news: it works :) great work!
> > 
> > Slightly less good news, I found two issues:
> > 
> > 1. Build failed because of missing include dir for libkdcraw  (because of disc issues my system currently uses kdelibs from packages so I installed gwenview and libkdcraw in a different prefix). This is fixed with this change:
> > 
> > diff --git a/CMakeLists.txt b/CMakeLists.txt
> > index adcd39c..5b13bb8 100644
> > --- a/CMakeLists.txt
> > +++ b/CMakeLists.txt
> > @@ -78,6 +78,7 @@ include_directories(
> >      ${KDE4_INCLUDES}
> >      ${EXIV2_INCLUDE_DIR}
> >      ${NEPOMUK_CORE_INCLUDE_DIR}
> > +    ${KDCRAW_INCLUDE_DIR}
> >      )
> >  
> >  ## dirs to build
> > 
> > 2. The ThumbnailProviderTest::testLoadLocal fails. I haven't investigated, but I think it is a regression with orientation handling of JPEG thumbnails. You can build and run all tests by entering the tests/ build dir and running `make check`.

Great news! :) Thanks for the catches, I have just uploaded patch fixing the two issues.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113397/#review43264
-----------------------------------------------------------


On Nov. 10, 2013, 11:10 a.m., Martin Kyral wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113397/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2013, 11:10 a.m.)
> 
> 
> Review request for Gwenview and Aurélien Gâteau.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> This is a review of patch enabling raw support in gwenview. It uses KDcraw to extract the embedded jpeg preview (most of the raw formats contain it for the purposes of quick viewing the photos on the camera display) so it is fast, implementing was quite easy and theoretically it enables gwenview to support everything dcraw supports (practically we need to test more formats). The patch does not perform demosaicing and I don't think it shall - digikam, darktable or rawtherapee are much more suited for developing the 'digital negatives'.
> 
> The patch fixes BZ#158788
> 
> The patch enables support for Nikon NEF and NRW formats, Canon's CR2, Pentax PEF, Sony ARW and Adobe DNG. If you want to try another format, just adding it's MIME type to the list in lib/mimetypeutils.cpp shall be enough.
> 
> The patch as is contains just the basic functionality (generating proper thumbnails and viewing the raw images incl. EXIF metadata), but it is well usable. However, there is still a lot of stuff to do (see the commit message in the patch) so I'd appreciate any help.
> 
> 
> Diffs
> -----
> 
>   lib/CMakeLists.txt c6ffe14 
>   CMakeLists.txt 4dafb7e 
>   lib/document/loadingdocumentimpl.cpp fbad8ff 
>   lib/gwenviewconfig.kcfg 231fd5e 
>   lib/mimetypeutils.cpp 546346f 
>   lib/thumbnailprovider/thumbnailgenerator.cpp 8b98904 
> 
> Diff: http://git.reviewboard.kde.org/r/113397/diff/
> 
> 
> Testing
> -------
> 
> Tested on some sample raw files taken from the camera reviews on http://www.photographyblog.com/ and bunch of my own photos. Nikon (tried D50, D70s, D90, D800 and Coolpix P7000), Canon (tried 7D, 5D Mark3 and 6D) and Pentax (K-X, K30) have the preview full-res, while Sony raw files (A900, A850, A58, Nex 3, Nex 6) have only 1616x1050.
> 
> 
> Thanks,
> 
> Martin Kyral
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20131110/b5a709e5/attachment.html>