Review Request 113397: RAW preview in gwenview

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113397/#review43199
-----------------------------------------------------------


Great news regarding kdcraw getting the necessary changes, it's nice to keep the changes to the minimum.

Regarding the loading of half previews: next time, avoid adding new features in the middle of the review. Even if the feature is a good idea (it is!) if you keep adding code that thing is never going to land.


CMakeLists.txt
<http://git.reviewboard.kde.org/r/113397/#comment31133>

    Now that we rely on a very recent version of kdcraw, you should define the minimum version here, to catch problems earlier.



lib/document/loadingdocumentimpl.cpp
<http://git.reviewboard.kde.org/r/113397/#comment31134>

    Use a "const int", not a #define



lib/document/loadingdocumentimpl.cpp
<http://git.reviewboard.kde.org/r/113397/#comment31135>

    Can be simplified into:
    
    qMin(originalImage.width(), originalImage.height()) < MIN_PREV_SIZE



lib/document/loadingdocumentimpl.cpp
<http://git.reviewboard.kde.org/r/113397/#comment31136>

    I am a bit worried about this: what is the value of mFormat in the case of previewing a raw file?



lib/thumbnailprovider/thumbnailgenerator.cpp
<http://git.reviewboard.kde.org/r/113397/#comment31137>

    Use a "const int", not a #define



lib/thumbnailprovider/thumbnailgenerator.cpp
<http://git.reviewboard.kde.org/r/113397/#comment31140>

    Reading this again, I don't understand the comment: why do you consider loading the image from data a dirty hack?



lib/thumbnailprovider/thumbnailgenerator.cpp
<http://git.reviewboard.kde.org/r/113397/#comment31138>

    same optimization as before



lib/thumbnailprovider/thumbnailgenerator.cpp
<http://git.reviewboard.kde.org/r/113397/#comment31142>

    I don't have an opinion regarding raw files, but in the case of jpeg, I really want the code to use the embedded thumbnail if it is available.



lib/thumbnailprovider/thumbnailgenerator.cpp
<http://git.reviewboard.kde.org/r/113397/#comment31139>

    optimization: use !content.rawData().isEmpty() instead of checking the size
    
    nitpick: space before '('


- Aurélien Gâteau


On Nov. 6, 2013, 3:23 p.m., Martin Kyral wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113397/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2013, 3:23 p.m.)
> 
> 
> Review request for Gwenview and Aurélien Gâteau.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> This is a review of patch enabling raw support in gwenview. It uses KDcraw to extract the embedded jpeg preview (most of the raw formats contain it for the purposes of quick viewing the photos on the camera display) so it is fast, implementing was quite easy and theoretically it enables gwenview to support everything dcraw supports (practically we need to test more formats). The patch does not perform demosaicing and I don't think it shall - digikam, darktable or rawtherapee are much more suited for developing the 'digital negatives'.
> 
> The patch fixes BZ#158788
> 
> The patch enables support for Nikon NEF and NRW formats, Canon's CR2, Pentax PEF, Sony ARW and Adobe DNG. If you want to try another format, just adding it's MIME type to the list in lib/mimetypeutils.cpp shall be enough.
> 
> The patch as is contains just the basic functionality (generating proper thumbnails and viewing the raw images incl. EXIF metadata), but it is well usable. However, there is still a lot of stuff to do (see the commit message in the patch) so I'd appreciate any help.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4dafb7e 
>   lib/CMakeLists.txt c6ffe14 
>   lib/document/loadingdocumentimpl.cpp fbad8ff 
>   lib/gwenviewconfig.kcfg 231fd5e 
>   lib/mimetypeutils.cpp 546346f 
>   lib/thumbnailprovider/thumbnailgenerator.cpp 8b98904 
> 
> Diff: http://git.reviewboard.kde.org/r/113397/diff/
> 
> 
> Testing
> -------
> 
> Tested on some sample raw files taken from the camera reviews on http://www.photographyblog.com/ and bunch of my own photos. Nikon (tried D50, D70s, D90, D800 and Coolpix P7000), Canon (tried 7D, 5D Mark3 and 6D) and Pentax (K-X, K30) have the preview full-res, while Sony raw files (A900, A850, A58, Nex 3, Nex 6) have only 1616x1050.
> 
> 
> Thanks,
> 
> Martin Kyral
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20131107/59831029/attachment-0001.html>