Review Request 113397: RAW preview in gwenview

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113397/#review43083
-----------------------------------------------------------


Hi, sorry for the late reply. A few new issues, but we are getting there, thanks for all your work!


lib/document/loadingdocumentimpl.cpp
<http://git.reviewboard.kde.org/r/113397/#comment31066>

    nitpick: remove commented code



lib/document/loadingdocumentimpl.cpp
<http://git.reviewboard.kde.org/r/113397/#comment31067>

    This block can stay where it was (outside of ifs but after the potential call to loadEmbeddedPreview() so that mData has useful info). This avoids duplication and also makes it possible for Exif info to be loaded from other image formats (Exiv2 supports extracting info from TIFF, PNG...)



lib/thumbnailprovider/thumbnailgenerator.cpp
<http://git.reviewboard.kde.org/r/113397/#comment31068>

    I don't think you need the cast here.



lib/thumbnailprovider/thumbnailgenerator.cpp
<http://git.reviewboard.kde.org/r/113397/#comment31069>

    It looks to me like the new code is never going to use the embedded thumbnail, this could have a bad impact on performance.


- Aurélien Gâteau


On Oct. 30, 2013, 2:17 p.m., Martin Kyral wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113397/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2013, 2:17 p.m.)
> 
> 
> Review request for Gwenview and Aurélien Gâteau.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> This is a review of patch enabling raw support in gwenview. It uses KDcraw to extract the embedded jpeg preview (most of the raw formats contain it for the purposes of quick viewing the photos on the camera display) so it is fast, implementing was quite easy and theoretically it enables gwenview to support everything dcraw supports (practically we need to test more formats). The patch does not perform demosaicing and I don't think it shall - digikam, darktable or rawtherapee are much more suited for developing the 'digital negatives'.
> 
> The patch fixes BZ#158788
> 
> The patch enables support for Nikon NEF and NRW formats, Canon's CR2, Pentax PEF, Sony ARW and Adobe DNG. If you want to try another format, just adding it's MIME type to the list in lib/mimetypeutils.cpp shall be enough.
> 
> The patch as is contains just the basic functionality (generating proper thumbnails and viewing the raw images incl. EXIF metadata), but it is well usable. However, there is still a lot of stuff to do (see the commit message in the patch) so I'd appreciate any help.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4dafb7e 
>   lib/CMakeLists.txt c6ffe14 
>   lib/document/loadingdocumentimpl.cpp fbad8ff 
>   lib/gvlibraw.h PRE-CREATION 
>   lib/gvlibraw.cpp PRE-CREATION 
>   lib/gwenviewconfig.kcfg 231fd5e 
>   lib/mimetypeutils.cpp 546346f 
>   lib/thumbnailprovider/thumbnailgenerator.cpp 8b98904 
> 
> Diff: http://git.reviewboard.kde.org/r/113397/diff/
> 
> 
> Testing
> -------
> 
> Tested on some sample raw files taken from the camera reviews on http://www.photographyblog.com/ and bunch of my own photos. Nikon (tried D50, D70s, D90, D800 and Coolpix P7000), Canon (tried 7D, 5D Mark3 and 6D) and Pentax (K-X, K30) have the preview full-res, while Sony raw files (A900, A850, A58, Nex 3, Nex 6) have only 1616x1050.
> 
> 
> Thanks,
> 
> Martin Kyral
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20131105/4b8a649f/attachment.html>