Review Request 122722: Graphics: Port Filemesh example

Arjen Hiemstra ahiemstra at heimr.nl
Thu Feb 26 00:11:50 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122722/#review76641
-----------------------------------------------------------

Ship it!


Feel free to push once you fix the minor nitpick mentioned below, no need to upload a new diff.


graphics/examples/filemesh/main.cpp
<https://git.reviewboard.kde.org/r/122722/#comment52795>

    Minor nitpick: please use "" instead of <> for consistency.
    
    (Ideally, these would actually use <gluon/$module/$file> style since that is what you'd do outside of the source repo, but well, that's something for later)


- Arjen Hiemstra


On Feb. 25, 2015, 6:26 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122722/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2015, 6:26 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Repository: gluon
> 
> 
> Description
> -------
> 
> Compiles, but the rendering looks wrong
> 
> 
> Diffs
> -----
> 
>   graphics/examples/filemesh/CMakeLists.txt d4414a8 
>   graphics/examples/filemesh/main.cpp ee77662 
>   graphics/examples/CMakeLists.txt 2a15b4e 
> 
> Diff: https://git.reviewboard.kde.org/r/122722/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20150226/bb6e3a17/attachment.html>


More information about the Gluon mailing list