Review Request 123257: Port QtQuickRenderer to Qt5

[Arjen Hiemstra]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123257/#review78703
-----------------------------------------------------------


Several things below. In addition, please check your whitespace, the diff shows lots of additions.


graphics/glx/glxbuffer.h (line 47)
<https://git.reviewboard.kde.org/r/123257/#comment53855>

    Unnecessary method



graphics/glx/glxcontext.h (line 27)
<https://git.reviewboard.kde.org/r/123257/#comment53854>

    Unneeded forward declaration



graphics/glx/glxcontext.cpp (line 151)
<https://git.reviewboard.kde.org/r/123257/#comment53853>

    This removes the check for currentWindow, do we really want that?



graphics/glx/glxcontext.cpp (line 204)
<https://git.reviewboard.kde.org/r/123257/#comment53851>

    Can we move this to QtQuickRenderer? As it is very QtQuickRenderer specific.



graphics/glx/glxcontext.cpp (line 207)
<https://git.reviewboard.kde.org/r/123257/#comment53852>

    This should be named currentWindow()



graphics/glx/glxoutputsurface.cpp (line 24)
<https://git.reviewboard.kde.org/r/123257/#comment53848>

    Please remove the unneccessary include, especially since it makes things depend on QtWidgets.



graphics/glx/glxqtquickrendererprivate.cpp (line 63)
<https://git.reviewboard.kde.org/r/123257/#comment53850>

    Can we move some of this functionality into the base class? Most of the actual QML initialisation should be done for all the backends.



graphics/glx/glxrendertarget.h (line 39)
<https://git.reviewboard.kde.org/r/123257/#comment53849>

    Code style: Use fbo() or so, no 'get'


- Arjen Hiemstra


On April 4, 2015, 10:45 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123257/
> -----------------------------------------------------------
> 
> (Updated April 4, 2015, 10:45 p.m.)
> 
> 
> Review request for Gluon and Arjen Hiemstra.
> 
> 
> Repository: gluon
> 
> 
> Description
> -------
> 
> Seems like we finally got something working here :)
> 
> 
> Diffs
> -----
> 
>   graphics/CMakeLists.txt aea38d0 
>   graphics/backend.h 445f4f5 
>   graphics/examples/CMakeLists.txt 9ac8294 
>   graphics/examples/quickrenderer/CMakeLists.txt PRE-CREATION 
>   graphics/examples/quickrenderer/example.qml PRE-CREATION 
>   graphics/examples/quickrenderer/main.cpp PRE-CREATION 
>   graphics/glx/CMakeLists.txt f1d157d 
>   graphics/glx/glxbackend.h 2f799e0 
>   graphics/glx/glxbackend.cpp 09d23ef 
>   graphics/glx/glxbuffer.h 072a208 
>   graphics/glx/glxbuffer.cpp 2e744e5 
>   graphics/glx/glxcontext.h 5587e59 
>   graphics/glx/glxcontext.cpp e6d9ce5 
>   graphics/glx/glxoutputsurface.cpp 9df09c0 
>   graphics/glx/glxqtquickrenderer.h PRE-CREATION 
>   graphics/glx/glxqtquickrenderer.cpp PRE-CREATION 
>   graphics/glx/glxqtquickrendererprivate.h PRE-CREATION 
>   graphics/glx/glxqtquickrendererprivate.cpp PRE-CREATION 
>   graphics/glx/glxrendertarget.h d443063 
>   graphics/glx/glxrendertarget.cpp 9f644db 
>   graphics/qtquickrenderer.h a3248c0 
>   graphics/qtquickrenderer.cpp 67afa7b 
>   graphics/rendertarget.cpp 47ee908 
>   graphics/renderwindow.cpp 180f327 
> 
> Diff: https://git.reviewboard.kde.org/r/123257/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20150409/6fd7ee16/attachment.html>