Review Request 109937: updated diff

Shreya Pandit shreya.pandit25 at gmail.com
Tue Apr 9 17:17:10 UTC 2013 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109937/
-----------------------------------------------------------

(Updated April 9, 2013, 5:17 p.m.)


Review request for Gluon, Arjen Hiemstra and Dan Leinir Turthra Jensen.


Description
-------


Diffs
-----

  .gitignore 762fd3d 
  CMakeLists.txt 797d9d2 
  audio/tests/playertest.h 09319f8 
  core/CMakeLists.txt b7931f5 
  core/axisalignedbox.h 9c0b666 
  core/axisalignedbox.cpp 1e36217 
  core/debughelper.cpp 777868d 
  core/gluonobject.h 5b6f83f 
  core/singleton.h 158fd00 
  creator/CMakeLists.txt 4218c06 
  creator/dialogs/newprojectdialogpage.cpp c8728dd 
  creator/dialogs/openprojectdialogpage.h c4eb1e3 
  creator/dialogs/openprojectdialogpage.cpp 203d2f2 
  creator/dialogs/projectselectiondialog.h 4d53a95 
  creator/dialogs/projectselectiondialog.cpp 6da27b9 
  creator/dialogs/recentprojectsdialogpage.h d4c36e8 
  creator/dialogs/recentprojectsdialogpage.cpp ef6a222 
  creator/dialogs/welcomedialog.h PRE-CREATION 
  creator/dialogs/welcomedialog.cpp PRE-CREATION 
  creator/gluon-creator.desktop 88e21ee 
  creator/introslideshow.h PRE-CREATION 
  creator/introslideshow.cpp PRE-CREATION 
  creator/lib/gluoncreator_plugin.desktop 6a5b166 
  creator/lib/models/scenemodel.h 16e43e7 
  creator/lib/models/scenemodel.cpp cc15ca1 
  creator/lib/pluginmanager.cpp 90c4118 
  creator/main.cpp 3f3bb92 
  creator/mainwindow.h f9335ff 
  creator/mainwindow.cpp e50efb2 
  creator/plugins/docks/componentsdock/gluon_creator_dockplugin_componentsdock.desktop 3de0141 
  creator/plugins/docks/distributiondock/distributiondock.cpp d285766 
  creator/plugins/docks/distributiondock/gluon_creator_dockplugin_distributiondock.desktop a86bc74 
  creator/plugins/docks/messagedock/gluon_creator_dockplugin_messagedock.desktop 6cc4a63 
  creator/plugins/docks/projectdock/gluon_creator_dockplugin_projectdock.desktop b273537 
  creator/plugins/docks/propertiesdock/gluon_creator_dockplugin_propertiesdock.desktop ae58322 
  creator/plugins/docks/propertiesdock/propertywidgetitems/qvariantlistpropertywidgetitem.h 09e5d41 
  creator/plugins/docks/scenedock/gluon_creator_dockplugin_scenedock.desktop 13eca7d 
  creator/plugins/kparts/codeeditorpart/gluon_creator_codewidgetkpart.desktop 111e88d 
  creator/plugins/kparts/gluoneditorpart/gluon_editor_part.desktop 99f52f4 
  creator/plugins/kparts/gluonviewerpart/gluon_viewer_part.desktop 24b1355 
  creator/plugins/kparts/gluonviewerpart/gluonviewerpart.cpp 6f97c05 
  creator/plugins/tools/projectinspector/gluon_creator_toolplugin_projectinspector.desktop 28022ab 
  creator/plugins/tools/vcs/gluon_creator_toolplugin_vcstool.desktop 92f2227 
  creator/ui/CustomText.qml PRE-CREATION 
  creator/ui/introduction.qml PRE-CREATION 
  engine/achievementsmanager.h 1823b64 
  engine/asset.h 5a0d240 
  engine/assets/CMakeLists.txt 864f75e 
  engine/assets/graphics/material/materialasset.h 175509d 
  engine/assets/graphics/material/materialasset.cpp 08db31b 
  engine/assets/graphics/qtquick/CMakeLists.txt 36cd8d0 
  engine/assets/graphics/qtquick/qtquickasset.h 71eb70d 
  engine/assets/graphics/qtquick/qtquickasset.cpp 2af86d4 
  engine/assets/graphics/texture/textureasset.h 2e24fe8 
  engine/assets/graphics/texture/textureasset.cpp 550b7f5 
  engine/component.h 262d181 
  engine/component.cpp 6674587 
  engine/components/CMakeLists.txt 527d5c7 
  engine/components/graphics/animatedspriterenderer/animatedspriterenderercomponent.h d9ec024 
  engine/components/graphics/animatedspriterenderer/animatedspriterenderercomponent.cpp d49ed99 
  engine/components/graphics/beamrenderer/beamrenderercomponent.cpp 13248af 
  engine/components/graphics/cameracontroller/cameracontrollercomponent.h 8ebc1f6 
  engine/components/graphics/cameracontroller/cameracontrollercomponent.cpp 9a92513 
  engine/components/graphics/discrenderer/discrenderercomponent.cpp 6280b82 
  engine/components/graphics/discsectionrenderer/discsectionrenderercomponent.cpp 5b9406c 
  engine/components/graphics/interfacerenderer/CMakeLists.txt 6f48e5f 
  engine/components/graphics/interfacerenderer/interfacerenderercomponent.h 7f6d90e 
  engine/components/graphics/interfacerenderer/interfacerenderercomponent.cpp 7044ffb 
  engine/components/graphics/interfacerenderer/textureimageprovider.h aad9f71 
  engine/components/graphics/interfacerenderer/textureimageprovider.cpp e81a83d 
  engine/components/graphics/meshrenderer/meshrenderercomponent.cpp 771cca8 
  engine/components/graphics/particle/particlecomponent.cpp 845027d 
  engine/components/graphics/particlecollider/particlecollidercomponent.cpp b47a8c3 
  engine/components/graphics/spriterenderer/spriterenderercomponent.h 5a6badb 
  engine/components/graphics/spriterenderer/spriterenderercomponent.cpp f5363c6 
  engine/components/graphics/uimanager/uimanagercomponent.cpp ef2cb17 
  engine/components/input/keyboardinput/keyboardinputcomponent.cpp 3e1156e 
  engine/components/input/touchinput/touchinputcomponent.cpp 54d82ea 
  engine/components/other/btcomponents/viewconeprivate.h 3a307f7 
  engine/components/other/qtscript/qtscriptcomponent.h d10ef11 
  engine/components/scripting/scripting_template.js cc263a4 
  engine/components/scripting/scriptingengine.cpp 88f3f9d 
  engine/gameobject.h 5db229c 
  engine/gameobject.cpp 0e0c7dd 
  graphics/CMakeLists.txt 3bf8a06 
  graphics/abstractmesh.h PRE-CREATION 
  graphics/abstractmesh.cpp PRE-CREATION 
  graphics/backend.h ba40852 
  graphics/backendcapabilities.h PRE-CREATION 
  graphics/backendcapabilities.cpp PRE-CREATION 
  graphics/buffer.h 64d48a8 
  graphics/camera.h 30e72d4 
  graphics/camera.cpp 6ef8a11 
  graphics/cmake/FindAssImp.cmake 4f1563f 
  graphics/default.gml PRE-CREATION 
  graphics/default.png PRE-CREATION 
  graphics/design/classes.txt 0d34af7 
  graphics/engine.h PRE-CREATION 
  graphics/engine.cpp PRE-CREATION 
  graphics/entity.h 825d72a 
  graphics/entity.cpp 58a0330 
  graphics/examples/CMakeLists.txt d75e64f 
  graphics/examples/basic/main.cpp a36f144 
  graphics/examples/filemesh/CMakeLists.txt db8d028 
  graphics/examples/filemesh/duck.gluonmaterial 6b39281 
  graphics/examples/filemesh/main.cpp 4364140 
  graphics/examples/loadtexture/main.cpp 20c5e89 
  graphics/filemesh.h 2595b5a 
  graphics/filemesh.cpp d949fde 
  graphics/frustrum.h edc2a6c 
  graphics/frustrum.cpp 7f210c8 
  graphics/glheaders.h PRE-CREATION 
  graphics/glx/CMakeLists.txt c873942 
  graphics/glx/glxbackend.h b786c41 
  graphics/glx/glxbackend.cpp ba48fd5 
  graphics/glx/glxbuffer.h b733842 
  graphics/glx/glxbuffer.cpp b90cc7e 
  graphics/glx/glxcontext.h 8b16490 
  graphics/glx/glxcontext.cpp b4c7d6c 
  graphics/glx/glxfunctions.h 69b31ae 
  graphics/glx/glxfunctions.cpp 693c12f 
  graphics/glx/glxmeshdata.h e8b7d19 
  graphics/glx/glxmeshdata.cpp 4262f6a 
  graphics/glx/glxoutputsurface.h 2de3bcf 
  graphics/glx/glxoutputsurface.cpp 96f3e71 
  graphics/glx/glxrendertarget.h d443063 
  graphics/glx/glxrendertarget.cpp 9f644db 
  graphics/glx/glxshader.h 2964c8b 
  graphics/glx/glxshader.cpp ddb8539 
  graphics/glx/glxtexturedata.h 47b884b 
  graphics/glx/glxtexturedata.cpp 44e57d1 
  graphics/item.h PRE-CREATION 
  graphics/item.cpp PRE-CREATION 
  graphics/manager.h 4caf815 
  graphics/manager.cpp 52bdbdf 
  graphics/material.h 30cde1b 
  graphics/material.cpp 0e7a65c 
  graphics/materialelement.h 988ecc9 
  graphics/materialelement.cpp a87763e 
  graphics/materialinstance.h e7a2ffd 
  graphics/materialinstance.cpp 8931708 
  graphics/mathutils.cpp 9902f96 
  graphics/mesh.h 03494fb 
  graphics/mesh.cpp 5ee3a16 
  graphics/meshdata.h a6c0793 
  graphics/meshdata.cpp 9f6ac0a 
  graphics/outputsurface.h 26cd52a 
  graphics/outputsurface.cpp 53b31df 
  graphics/qtquickrenderer.h 47c43d2 
  graphics/qtquickrenderer.cpp 19b6111 
  graphics/renderchainitem.h 69efcf2 
  graphics/renderchainitem.cpp 995d44e 
  graphics/rendertarget.h fdd77ae 
  graphics/rendertarget.cpp 54b69d6 
  graphics/renderwidget.h bd7b2ef 
  graphics/renderwidget.cpp 7c6e225 
  graphics/resources/default.gluonmaterial 17f52e7 
  graphics/resources/default.png 1b59af4 
  graphics/shader.h fc0e92a 
  graphics/shader.cpp 5fb5f19 
  graphics/sprite.h a103b19 
  graphics/sprite.cpp 0d26bfd 
  graphics/spritemesh.h 4cc25c9 
  graphics/spritemesh.cpp b9eea08 
  graphics/technique.h 5ca04b9 
  graphics/technique.cpp a447916 
  graphics/texture.h 9de79b6 
  graphics/texture.cpp 4ebc324 
  graphics/texturedata.h f49516d 
  graphics/vertex.h PRE-CREATION 
  graphics/vertex.cpp PRE-CREATION 
  graphics/vertexattribute.h PRE-CREATION 
  graphics/vertexattribute.cpp PRE-CREATION 
  graphics/vertexattribute_p.h PRE-CREATION 
  graphics/vertexbuffer.h PRE-CREATION 
  graphics/vertexbuffer.cpp PRE-CREATION 
  graphics/viewport.h df242c4 
  graphics/viewport.cpp aa5e35c 
  graphics/world.h 8079ddb 
  graphics/world.cpp 5887f6c 
  input/examples/devicesloop/gameloop.cpp cdcf9c3 
  input/examples/devicesloop/main.cpp 636fa3c 
  input/examples/listdevices/main.cpp da1b96d 
  input/inputmanager.h 32c8a63 
  player/CMakeLists.txt 9c02c32 
  player/active/gluonplayer-active.desktop cea6bae 
  player/active/package/contents/ui/CommentDelegate.qml 1a05f24 
  player/active/package/contents/ui/CommentsView.qml 434acbf 
  player/active/package/contents/ui/GameDetails.qml 425ed03 
  player/active/package/contents/ui/GameItem.qml 89bdaaa 
  player/active/package/contents/ui/player.qml a0e5d5d 
  player/active/package/metadata.desktop baf2979 
  player/active/src/CMakeLists.txt 5f5e526 
  player/active/src/kdeclarativemainwindow.h PRE-CREATION 
  player/active/src/kdeclarativemainwindow.cpp PRE-CREATION 
  player/active/src/kdeclarativeview.h PRE-CREATION 
  player/active/src/kdeclarativeview.cpp PRE-CREATION 
  player/active/src/mainwindow.h 9856ea4 
  player/active/src/mainwindow.cpp d02c69b 
  player/desktop/delegates/commentitemsviewdelegate.cpp 81870ec 
  player/desktop/gluonplayer-desktop.desktop b524753 
  player/desktop/loginform.cpp f8bafb5 
  player/desktop/mainwindow.h cf66847 
  player/desktop/mainwindow.cpp c6c636e 
  player/examples/apocalypse.gluon/assets/scripts/bullet.js b07b1c1 
  player/examples/apocalypse.gluon/assets/scripts/controller.js 2b4a763 
  player/examples/apocalypse.gluon/assets/scripts/crosshair.js 965444b 
  player/examples/apocalypse.gluon/assets/scripts/player.js d08ed5b 
  player/examples/apocalypse.gluon/assets/scripts/zombie.js 5ab12f8 
  player/examples/ball.gluon/assets/main_material.gml d82e3fb 
  player/examples/ball.gluon/assets/scripts/controller.js b430663 
  player/examples/ball.gluon/assets/scripts/player.js 32aa201 
  player/examples/ball.gluon/assets/scripts/trap.js 5388921 
  player/examples/invaders.gluon/assets/interface/menu_interface.qml 7515ddd 
  player/examples/invaders.gluon/assets/main_material.gml 60d62ce 
  player/examples/invaders.gluon/assets/scripts/bullet.js b121e2b 
  player/examples/invaders.gluon/assets/scripts/controller.js 6845856 
  player/examples/invaders.gluon/assets/scripts/enemy.js 08ce8b9 
  player/examples/invaders.gluon/assets/scripts/player.js 459886e 
  player/examples/invaders.gluon/game.gluonproject 3a57a72 
  player/examples/invaders.gluon/scenes/game.gluonscene fbcdb04 
  player/examples/invaders.gluon/scenes/menu.gluonscene 45185b1 
  player/examples/jumpnbump.gluon/assets/scripts/controller.js 916b005 
  player/examples/jumpnbump.gluon/assets/scripts/player1.js e8667cb 
  player/examples/jumpnbump.gluon/assets/scripts/player2.js 1186c59 
  player/examples/pong.gluon/assets/scripts/ball.js 2f1fb1f 
  player/examples/pong.gluon/assets/scripts/controller.js d71ef3a 
  player/examples/pong.gluon/assets/scripts/player1.js 20ec4d2 
  player/examples/pong.gluon/assets/scripts/player2.js 4cebadb 
  player/examples/snake.gluon/assets/scripts/controller.js 283b601 
  player/fremantle/gluonplayer-fremantle.desktop 44c7669 
  player/harmattan/gluonplayer-harmattan.desktop 807ade2 
  player/lib/CMakeLists.txt 3dfc19e 
  player/lib/gamedetailitem.h 825c0ec 
  player/lib/gamemanager.h 169538b 
  player/lib/models/allgameitemsmodel.h 8dfc116 
  player/lib/models/allgameitemsmodel.cpp 698b564 
  player/lib/models/commentitemsmodel.h ea44410 
  player/lib/models/commentitemsmodel.cpp 2c58f1f 
  player/lib/models/comments.gdl 8a0fc8d 
  player/lib/models/commentsmodel.h PRE-CREATION 
  player/lib/models/commentsmodel.cpp PRE-CREATION 
  player/lib/models/downloadablegamesmodel.h e56be8d 
  player/lib/models/gameitem.h 9261120 
  player/lib/models/gameitem.cpp a81367a 
  player/lib/models/highscores.gdl 01d80be 
  player/lib/models/highscoresmodel.cpp 5630078 
  player/lib/models/installedgamesmodel.h 9884d9d 
  player/lib/serviceprovider.h 9f41199 
  player/lib/serviceprovider.cpp b4e0388 
  player/plasmoid/gamedetailsoverlay.h 496631f 
  player/plasmoid/gamedetailsoverlay.cpp 703e810 
  player/plasmoid/loginform.cpp fec4bcf 
  player/plasmoid/plasma-applet-gluonplayer.desktop 6549e90 
  player/plasmoid/views/commentsview.cpp 8312231 
  player/plasmoid/views/commentsviewitem.cpp 58ba377 
  smarts/common/statnode.h 4139f1e 
  smarts/editor/gluon_bteditor.desktop e2b2930 
  smarts/lib/btbrain.h f798c38 
  smarts/lib/btcharacter.h 35615e7 
  smarts/lib/btfactory.h 6b817cd 
  smarts/lib/btnode.h 1de798a 
  smarts/lib/btparallelnode.h 6bf4c22 
  smarts/lib/btperception.h d2b7730 
  smarts/lib/btperceptionatom.h 56dbdb8 
  smarts/lib/btperceptioninfo.h 9ef40c9 
  smarts/lib/btperceptionviewcone.h 51377fc 
  smarts/lib/btprobselectornode.h 6722fbf 
  smarts/lib/btselectornode.h 7cfae90 
  smarts/lib/btsequencenode.h c707d86 
  smarts/lib/probnode.h 0442451 
  smarts/lib/tests/btnodetest.h de075d9 
  tools/astyle/astyle.sh d5b9f92 
  tools/astyle/astylerc 9aa1e52 
  tools/viewer/main.cpp a62b550 

Diff: http://git.reviewboard.kde.org/r/109937/diff/


Testing
-------


Thanks,

Shreya Pandit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20130409/21a497c0/attachment-0001.html>

More information about the Gluon mailing list