Review Request: Make GluonObject::findGlobalItemByName more strict
Commit Hook
null at kde.org
Sun Jan 29 13:21:55 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103761/#review10192
-----------------------------------------------------------
This review has been submitted with commit dbb007376c79e93a8ae4ce1c861d72ff0692039d by Felix Rohrbach to branch master.
- Commit Hook
On Jan. 22, 2012, 4:55 p.m., Felix Rohrbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103761/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2012, 4:55 p.m.)
>
>
> Review request for Gluon.
>
>
> Description
> -------
>
> Before, the root names didn't have to match. The last time I edited this function, parts of existing code relied on that behaviour. Now, I didn't see any problems with that anymore.
> (In the current HEAD of the master branch, you can see what happens with such unstrict behaviour ;)
>
>
> Diffs
> -----
>
> core/gluonobject.cpp c63b4cf
>
> Diff: http://git.reviewboard.kde.org/r/103761/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Felix Rohrbach
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20120129/31980d61/attachment.html>
More information about the Gluon
mailing list