Review Request: Load all assets when opening a project in gluon creator

Arjen Hiemstra djfreestyler at gmail.com
Mon Jan 16 12:48:41 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103689/#review9861
-----------------------------------------------------------

Ship it!


Looks fine to me, though I'm a bit scared at the logic populating GameProject::assets(), but that is unrelated. :)

- Arjen Hiemstra


On Jan. 13, 2012, 4:46 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103689/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2012, 4:46 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> This is done in ProjectModel::setProject.
> 
> 
> Diffs
> -----
> 
>   creator/lib/models/projectmodel.cpp f11ec9f 
> 
> Diff: http://git.reviewboard.kde.org/r/103689/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20120116/532dba7d/attachment.html>


More information about the Gluon mailing list