Review Request: Bounding boxes for GameObjects

Laszlo Papp lpapp at kde.org
Sun Dec 9 19:52:07 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106712/#review23220
-----------------------------------------------------------


I was wondering if it made more sense to use the term "axis-aligned bounding box" (AABB) for the filename and class rather than just "axis-aligned box". The former seems to be more common usage out there.

- Laszlo Papp


On Dec. 1, 2012, 3:16 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106712/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2012, 3:16 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> This adds bounding boxes for GameObjects, based on the patch for Components. I'm not really sure if the rotation works, as I don't have much experience in graphics.
> 
> 
> Diffs
> -----
> 
>   core/axisalignedbox.h 5d9cab1 
>   core/axisalignedbox.cpp 9e7e3eb 
>   engine/gameobject.h c042e94 
>   engine/gameobject.cpp a0d059f 
> 
> Diff: http://git.reviewboard.kde.org/r/106712/diff/
> 
> 
> Testing
> -------
> 
> Compiles (x86_64, Qt 4.8.3)
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20121209/1f8fe461/attachment.html>


More information about the Gluon mailing list