Review Request: Add functions to get the size of a component

[Arjen Hiemstra]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106047/#review17754
-----------------------------------------------------------



core/axisalignedbox.h
<http://git.reviewboard.kde.org/r/106047/#comment13936>

    Since you're returning a new AAB here, it is better to name it united() (Like QRect) or something similar.



core/axisalignedbox.cpp
<http://git.reviewboard.kde.org/r/106047/#comment13938>

    This does not seem to result in the right position. Consider two boxes with size 5 on all sides, one at ( 0, -5, 0 ) the other at ( 5, 5, 0 ). The size will correctly be ( 10, 15, 5 ) but the new position will be ( 0, -2.5, 2.5 ) whereas it should be ( 2.5, 0, 0 ). You need to divide size by 2 since each position is in the center of the box. 



engine/component.h
<http://git.reviewboard.kde.org/r/106047/#comment13937>

    No need to include AAB here, just forward-declare it and include it in the .cpp.


- Arjen Hiemstra


On Aug. 17, 2012, 1:28 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106047/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2012, 1:28 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> I'd like to have these functions to compute the size of GameObjects.
> 
> 
> Diffs
> -----
> 
>   core/CMakeLists.txt 3d94d84 
>   core/axisalignedbox.h PRE-CREATION 
>   core/axisalignedbox.cpp PRE-CREATION 
>   engine/component.h db86220 
>   engine/component.cpp 2999d84 
> 
> Diff: http://git.reviewboard.kde.org/r/106047/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20120820/1e041dc8/attachment.html>