Review Request: Add functions to get the size of a component
Felix Rohrbach
fxrh at gmx.de
Wed Aug 15 17:54:52 UTC 2012
> On Aug. 15, 2012, 5:44 p.m., Dan Leinir Turthra Jensen wrote:
> > engine/component.h, line 151
> > <http://git.reviewboard.kde.org/r/106047/diff/1/?file=78008#file78008line151>
> >
> > Hmm, not sure if it wouldn't make better sense to return a zero-size vector... Is it cheaper to check all the vectors for validity before adding, than it is to add them all up? Honestly i don't know, but i thought it worth raising the point :)
I just realized that there is no such thing as an invalid QVector3D, that only exists for QSize.
- Felix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106047/#review17468
-----------------------------------------------------------
On Aug. 15, 2012, 5:26 p.m., Felix Rohrbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106047/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2012, 5:26 p.m.)
>
>
> Review request for Gluon.
>
>
> Description
> -------
>
> I'd like to have these functions to compute the size of GameObjects.
>
>
> Diffs
> -----
>
> engine/component.h db86220
> engine/component.cpp 2999d84
>
> Diff: http://git.reviewboard.kde.org/r/106047/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Felix Rohrbach
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20120815/4108ab4e/attachment.html>
More information about the Gluon
mailing list