Review Request: Achievements 13: Add a selection option to Achievement if the statistic is TasksStatistic

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102720/#review6874
-----------------------------------------------------------

Ship it!


Very minor nitpicks (nothing to do with the functionality, cosmethical changes). The patch looks good for a short glance. =)


engine/achievement.h
<http://git.reviewboard.kde.org/r/102720/#comment6106>

    indices or "index numbers" would be better English here. Also, you can probably just write "string" without a capital letter if it is just a usual word not referring to QString or similar things.



engine/achievement.cpp
<http://git.reviewboard.kde.org/r/102720/#comment6105>

    bool ok1;
    bool ok2;
    
    or 
    
    bool ok1;
    statement
    bool ok2;
    statement
    
    We do not usually define more variables in one statement (even line);


- Laszlo Papp


On Sept. 27, 2011, 4:52 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102720/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2011, 4:52 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> This selection is a string that describes which indexes of the TasksStatistic array should be used for this achievement.
> Note that this patch only builds together with Achievements 12.
> 
> 
> Diffs
> -----
> 
>   engine/abstractstatistic.h 5cd8eb6 
>   engine/achievement.h 4a2d099 
>   engine/achievement.cpp d631383 
> 
> Diff: http://git.reviewboard.kde.org/r/102720/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110927/3a211e11/attachment.html>