Review Request: Achievements 10 fixup

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102569/#review6495
-----------------------------------------------------------

Ship it!


I would probably write "metaData is NULL, so the model will be empty." in the debug message  while pushing, but other than that, it is fine, thanks.

- Laszlo


On Sept. 13, 2011, 6:06 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102569/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2011, 6:06 p.m.)
> 
> 
> Review request for Gluon and Laszlo Papp.
> 
> 
> Summary
> -------
> 
> Fix showing the achievement icons in the kdeext player.
> 
> 
> Diffs
> -----
> 
>   player/lib/models/achievementsmodel.cpp 7f66f46 
> 
> Diff: http://git.reviewboard.kde.org/r/102569/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110914/7b57c47d/attachment.html>