Review Request: Achievements 10: icons, score

[Dan Leinir Turthra Jensen]

> On Sept. 10, 2011, 1:14 p.m., Dan Leinir Turthra Jensen wrote:
> > engine/achievementsmanager.h, line 83
> > <http://git.reviewboard.kde.org/r/102476/diff/4/?file=35391#file35391line83>
> >
> >     It'd be good to add a @return statement - in particular it'd be worth pointing out that if there are no statistics gathered, it will return 0 rather than some other number (one might guess, without docs, that it could return -1 if no statistics have been gathered, which of course it doesn't)
> 
> Felix Rohrbach wrote:
>     Well, actually it asserts if the index is wrong ;) I would just add "Index must be a valid index position, i.e. between 0 and achievementsCount()-1" to the documentation, as I did for all the other getters, as I think we already discussed once about this on IRC and came to that conclusion. Are you ok with that, too?

Ah, sorry, i commented on the wrong one - i meant the declaration in Achievement, not the one in AchievementsManager :D But yes, more verbose documentation would be good here as well :) Same stipulation, docs can be added after the push, the vote is still push it ;)


- Dan Leinir Turthra


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102476/#review6375
-----------------------------------------------------------


On Sept. 4, 2011, 10:50 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102476/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2011, 10:50 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Achievements now have icons, AchievementsManager saves the current Score
> 
> 
> Diffs
> -----
> 
>   engine/achievement.h 84018de 
>   engine/achievement.cpp 75cef86 
>   engine/achievementsmanager.h d2c35a3 
>   engine/achievementsmanager.cpp a657074 
>   player/lib/models/achievementsmodel.h ff55dfa 
>   player/lib/models/achievementsmodel.cpp cb5db2f 
> 
> Diff: http://git.reviewboard.kde.org/r/102476/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110910/5586aa5a/attachment.html>