Review Request: Achievements 10: icons, score

[Dan Leinir Turthra Jensen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102476/#review6375
-----------------------------------------------------------

Ship it!


Other than a little documentation stuff, this all looks good - the note is more a note, and shouldn't mean it isn't publishable. So, ship it :)


engine/achievementsmanager.h
<http://git.reviewboard.kde.org/r/102476/#comment5676>

    It'd be good to add a @return statement - in particular it'd be worth pointing out that if there are no statistics gathered, it will return 0 rather than some other number (one might guess, without docs, that it could return -1 if no statistics have been gathered, which of course it doesn't)


- Dan Leinir Turthra


On Sept. 4, 2011, 10:50 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102476/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2011, 10:50 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Achievements now have icons, AchievementsManager saves the current Score
> 
> 
> Diffs
> -----
> 
>   engine/achievement.h 84018de 
>   engine/achievement.cpp 75cef86 
>   engine/achievementsmanager.h d2c35a3 
>   engine/achievementsmanager.cpp a657074 
>   player/lib/models/achievementsmodel.h ff55dfa 
>   player/lib/models/achievementsmodel.cpp cb5db2f 
> 
> Diff: http://git.reviewboard.kde.org/r/102476/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110910/2a19af7b/attachment.html>