Review Request: Tests for GDLHandler

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102511/#review6336
-----------------------------------------------------------


I agree about the "documentation" removal with you since there was no real need for that.


core/tests/gdlhandlertest.cpp
<http://git.reviewboard.kde.org/r/102511/#comment5655>

    It seems to be leaking, how about this instead:
    
    bool result = compareTrees( parsedGluonObjectList, gh->parseGDL( serializedString, serializedString.size() ) );
    qDeleteAll(parsedGluonObjectList);
    return result;
    



core/tests/gdlhandlertest.cpp
<http://git.reviewboard.kde.org/r/102511/#comment5656>

    It seems to be leaking, how about this instead:
    
    bool result = compareTrees( parsedGluonObjectList, gluonObjectList);
    qDeleteAll(parsedGluonObjectList);
    return result;
    


- Laszlo


On Sept. 8, 2011, 1:54 p.m., Ashwin Rajeev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102511/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2011, 1:54 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Add few new test cases in gdlhandlertest
> {ensureParsing,ensureSerializing,ensureCommenting,testGDLSample,testCommentAtBegin,testCommentAtEnd}
>     
> Improve methods already in gdlhandlertest
> {compareTrees,compare_metaproperties,compare_dynproperties}
> 
> 
> Diffs
> -----
> 
>   core/tests/gdlhandlertest.h b0e3f72 
>   core/tests/gdlhandlertest.cpp c492a5d 
> 
> Diff: http://git.reviewboard.kde.org/r/102511/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashwin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110908/6a61dca0/attachment.html>