Review Request: Tests for GDLHandler

[Ashwin Rajeev]

> On Sept. 8, 2011, 9:58 a.m., Laszlo Papp wrote:
> > core/tests/gdlhandlertest.h, line 50
> > <http://git.reviewboard.kde.org/r/102511/diff/4/?file=35598#file35598line50>
> >
> >     Could you please use header-style function documentation, like:
> >     
> >     /**
> >      * Return ..
> >      */
> >     
> >     You can get a lot of examples from other header files. Also, if you start documenting the return value, it would be more consistent to also write few words about the argument.
> 
> Dan Leinir Turthra Jensen wrote:
>     What you mean to say is, please use Doxygen style comments ;)

i think it is better to remove that comment


- Ashwin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102511/#review6331
-----------------------------------------------------------


On Sept. 8, 2011, 8:57 a.m., Ashwin Rajeev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102511/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2011, 8:57 a.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Add few new test cases in gdlhandlertest
> {ensureParsing,ensureSerializing,ensureCommenting,testGDLSample,testCommentAtBegin,testCommentAtEnd}
>     
> Improve methods already in gdlhandler 
> 
> 
> Diffs
> -----
> 
>   core/tests/gdlhandlertest.h b0e3f72 
>   core/tests/gdlhandlertest.cpp c492a5d 
> 
> Diff: http://git.reviewboard.kde.org/r/102511/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashwin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110908/2cc37632/attachment.html>