Review Request: Tests for GDLHandler

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102511/#review6331
-----------------------------------------------------------



core/tests/gdlhandlertest.h
<http://git.reviewboard.kde.org/r/102511/#comment5645>

    Could you please use header-style function documentation, like:
    
    /**
     * Return ..
     */
    
    You can get a lot of examples from other header files. Also, if you start documenting the return value, it would be more consistent to also write few words about the argument.



core/tests/gdlhandlertest.cpp
<http://git.reviewboard.kde.org/r/102511/#comment5639>

    No need for spaces here since it is not used like that in this file at other places either.
    
    QList<GluonObject*> children* ... is good.



core/tests/gdlhandlertest.cpp
<http://git.reviewboard.kde.org/r/102511/#comment5638>

    How about names? Like:
    
    a) nonConstTemplateList
    b) constTemplateList
    c) templateObject
    



core/tests/gdlhandlertest.cpp
<http://git.reviewboard.kde.org/r/102511/#comment5640>

    parsedGluonObjectList ?



core/tests/gdlhandlertest.cpp
<http://git.reviewboard.kde.org/r/102511/#comment5641>

    parsedGluonObjectList ?



core/tests/gdlhandlertest.cpp
<http://git.reviewboard.kde.org/r/102511/#comment5642>

    parsedGluonObjectList ?



core/tests/gdlhandlertest.cpp
<http://git.reviewboard.kde.org/r/102511/#comment5643>

    parsedGluonObjectList ?



core/tests/gdlhandlertest.cpp
<http://git.reviewboard.kde.org/r/102511/#comment5644>

    parsedGluonObjectList ?


- Laszlo


On Sept. 8, 2011, 8:57 a.m., Ashwin Rajeev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102511/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2011, 8:57 a.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Add few new test cases in gdlhandlertest
> {ensureParsing,ensureSerializing,ensureCommenting,testGDLSample,testCommentAtBegin,testCommentAtEnd}
>     
> Improve methods already in gdlhandler 
> 
> 
> Diffs
> -----
> 
>   core/tests/gdlhandlertest.h b0e3f72 
>   core/tests/gdlhandlertest.cpp c492a5d 
> 
> Diff: http://git.reviewboard.kde.org/r/102511/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashwin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110908/9424a0b8/attachment-0001.html>