Review Request: Tests for GDLHandler
Ashwin Rajeev
ashwin_rajeev at hotmail.com
Tue Sep 6 17:29:54 UTC 2011
> On Sept. 6, 2011, 4:51 p.m., Laszlo Papp wrote:
> > core/tests/gdlhandlertest.h, line 43
> > <http://git.reviewboard.kde.org/r/102511/diff/1/?file=33349#file33349line43>
> >
> > why not follow the previous gluonObject1/2 schema we started doing in order to make more talkative ?
sorry,there is no method compareChildren i forgot to remove it from declaration
- Ashwin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102511/#review6304
-----------------------------------------------------------
On Sept. 1, 2011, 6:33 p.m., Ashwin Rajeev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102511/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2011, 6:33 p.m.)
>
>
> Review request for Gluon.
>
>
> Summary
> -------
>
> Add few new test cases in gdlhandlertest
> {ensureParsing,ensureSerializing,ensureCommenting,testGDLSample,testCommentAtBegin,testCommentAtEnd}
>
> Modify compareTrees method to check children of gluonobjects
>
>
> Diffs
> -----
>
> core/tests/gdlhandlertest.h 94a33c9
> core/tests/gdlhandlertest.cpp 90ac380
>
> Diff: http://git.reviewboard.kde.org/r/102511/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashwin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110906/6d61217f/attachment.html>
More information about the Gluon
mailing list