Review Request: Achievements 10: icons, score

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102476/#review6265
-----------------------------------------------------------


I am sorry for not spotifying these minor issues earlier. These are just remarks on my side, not a blocker against pushing by any mean. Thanks for the modifications in the player part.


engine/achievement.h
<http://git.reviewboard.kde.org/r/102476/#comment5511>

    s/store/score/



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102476/#comment5512>

    Not the addition of this patch, but unneccessary space here. (maybe could be fixed up in this patch instead of a one-character fix in a separate one? :p)


- Laszlo


On Sept. 3, 2011, 3:02 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102476/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2011, 3:02 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Achievements now have icons, AchievementsManager saves the current Score
> 
> 
> Diffs
> -----
> 
>   engine/achievement.h 84018de 
>   engine/achievement.cpp 75cef86 
>   engine/achievementsmanager.h d2c35a3 
>   engine/achievementsmanager.cpp a657074 
>   player/lib/models/achievementsmodel.h ff55dfa 
>   player/lib/models/achievementsmodel.cpp cb5db2f 
> 
> Diff: http://git.reviewboard.kde.org/r/102476/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110904/f9ff1a2a/attachment.html>