Review Request: More Changes in GluonObject

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102792/#review7153
-----------------------------------------------------------


This review has been submitted with commit 8381ec9dcc070f11a64b07f6d31884d912c9ee25 by Felix Rohrbach to branch master.

- Commit Hook


On Oct. 6, 2011, 3:14 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102792/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2011, 3:14 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> 1. Change qualifiedName again. Now, it doesn't include the name of the local root, so that it works better together with findItemByName
> 2. findItemByName:
>           a) Remove a check that removed the first object in the path if it has the same name as "this". As a child can have the same name as its parent, this may create false paths.
>           b) As a) removes the possibility to find objects with the full path, add a function findGlobalItemByName and use it where it replaces findItemByName.
> 
> 
> Diffs
> -----
> 
>   core/gluonobject.h 60b47be 
>   core/gluonobject.cpp 8f8bfe8 
>   core/tests/gluonobjecttest.cpp e39e161 
>   creator/lib/models/projectmodel.cpp 002f0e0 
>   creator/lib/models/scenemodel.cpp fc6cd8c 
>   creator/nodeeditor/interface/NodeEditor.cpp 94a9f68 
>   engine/components/graphics/animatedspriterenderer/animatedspriterenderercomponent.cpp cf140b1 
>   engine/components/graphics/beamrenderer/beamrenderercomponent.cpp f8fb058 
>   engine/components/graphics/meshrenderer/meshrenderercomponent.cpp e218cbe 
>   engine/components/graphics/particle/particlerenderer.cpp 7f01fd2 
>   engine/components/graphics/spriterenderer/spriterenderercomponent.cpp 453afa9 
>   engine/components/graphics/uimanager/textureimageprovider.cpp 069a086 
>   engine/game.cpp 138e8d6 
> 
> Diff: http://git.reviewboard.kde.org/r/102792/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111006/3fc0b7b1/attachment.html>