Review Request: Fix GluonObject::qualifiedName and the related test
Dan Leinir Turthra Jensen
admin at leinir.dk
Mon Oct 3 22:33:07 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102767/#review7058
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Leinir Turthra Jensen
On Oct. 3, 2011, 10:30 p.m., Felix Rohrbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102767/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2011, 10:30 p.m.)
>
>
> Review request for Gluon and Dan Leinir Turthra Jensen.
>
>
> Description
> -------
>
> Now, it should finally work :)
> You get localRoot->name()/.../.../this->name(). If localRoot == this, you get name(). If localRoot is not a parent (or a parent of a parent etc.), you get the same result as with fullyQualifiedName.
>
>
> Diffs
> -----
>
> core/gluonobject.cpp a1e7ac9
> core/tests/gluonobjecttest.cpp c5e3812
>
> Diff: http://git.reviewboard.kde.org/r/102767/diff/diff
>
>
> Testing
> -------
>
> The tests pass and invaders still runs
>
>
> Thanks,
>
> Felix Rohrbach
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111003/1653c414/attachment-0001.html>
More information about the Gluon
mailing list