Review Request: Fix GluonObject::qualifiedName and the related test

Felix Rohrbach fxrh at gmx.de
Mon Oct 3 22:30:12 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102767/
-----------------------------------------------------------

Review request for Gluon and Dan Leinir Turthra Jensen.


Description
-------

Now, it should finally work :)
You get localRoot->name()/.../.../this->name(). If localRoot == this, you get name(). If localRoot is not a parent (or a parent of a parent etc.), you get the same result as with fullyQualifiedName.


Diffs
-----

  core/gluonobject.cpp a1e7ac9 
  core/tests/gluonobjecttest.cpp c5e3812 

Diff: http://git.reviewboard.kde.org/r/102767/diff/diff


Testing
-------

The tests pass and invaders still runs


Thanks,

Felix Rohrbach

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111003/c4353912/attachment.html>


More information about the Gluon mailing list