Review Request: 3 small changes for GluonObject
Dan Leinir Turthra Jensen
admin at leinir.dk
Mon Oct 3 17:32:31 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102766/#review7049
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Leinir Turthra Jensen
On Oct. 3, 2011, 5:24 p.m., Felix Rohrbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102766/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2011, 5:24 p.m.)
>
>
> Review request for Gluon and Dan Leinir Turthra Jensen.
>
>
> Description
> -------
>
> - qualifiedName: make argument constant
> - qualifiedName: do the recursion with qualifiedName, not fullyQualifiedName (I guess that's what you meant, currently the code doesn't make any sense at all)
> - findItemByNameInObject: add a check to prevent crashes
>
>
> Diffs
> -----
>
> core/gluonobject.h 3511b58
> core/gluonobject.cpp 505d064
>
> Diff: http://git.reviewboard.kde.org/r/102766/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Felix Rohrbach
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111003/951f571d/attachment.html>
More information about the Gluon
mailing list