Review Request: Achievements 20: Add a threshold value to the Achievement class
Felix Rohrbach
fxrh at gmx.de
Sat Nov 26 20:28:00 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103253/
-----------------------------------------------------------
(Updated Nov. 26, 2011, 8:28 p.m.)
Review request for Gluon.
Changes
-------
All changes as suggested
Description (updated)
-------
With this threshold value you define when the player starts to make progress. Hidden achievements will be shown as soon as the player starts to make progress.
Further changes:
- AchievementsManager::dependency now returns the index of the dependency
This is the last commit in my achievements branch :). After that, only the new delegate (which I have to rewrite) is missing.
Diffs (updated)
-----
engine/achievement.h 5d8403a
engine/achievement.cpp 4a5e544
engine/achievementsmanager.h 785226a
engine/achievementsmanager.cpp ae95ddd
Diff: http://git.reviewboard.kde.org/r/103253/diff/diff
Testing
-------
Thanks,
Felix Rohrbach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111126/6b39da4b/attachment-0001.html>
More information about the Gluon
mailing list