Review Request: Achievements 19: Add BooleanStatistic class

Arjen Hiemstra djfreestyler at gmail.com
Sat Nov 26 18:13:58 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103251/#review8493
-----------------------------------------------------------



engine/booleanstatistic.h
<http://git.reviewboard.kde.org/r/103251/#comment7209>

    Here as well, use isChecked instead of just checked.


- Arjen Hiemstra


On Nov. 26, 2011, 3:44 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103251/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2011, 3:44 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> This statistic only saves 0 or 1. This might be useful if there is a single event that should be tracked, like "kill boss X".
> 
> 
> Diffs
> -----
> 
>   engine/CMakeLists.txt 45b2932 
>   engine/assets/other/statistics/statisticsasset.h 5c5756c 
>   engine/assets/other/statistics/statisticsasset.cpp 7b85f20 
>   engine/booleanstatistic.h PRE-CREATION 
>   engine/booleanstatistic.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103251/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111126/e1dc13de/attachment-0001.html>


More information about the Gluon mailing list