Review Request: Achievements 18: Add hidden achievement option

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103249/#review8491
-----------------------------------------------------------



engine/achievement.h
<http://git.reviewboard.kde.org/r/103249/#comment7205>

    Why not "hidden" term ? In your next patch for instance, you use in such a case: "checked". I prefer the second version.
    
    Although, this terming issue might be avoided by using the term "visible", like in case of widgets and so on.



engine/achievement.cpp
<http://git.reviewboard.kde.org/r/103249/#comment7206>

    same issue as above



engine/achievement.cpp
<http://git.reviewboard.kde.org/r/103249/#comment7207>

    same issue as above


- Laszlo Papp


On Nov. 26, 2011, 3:39 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103249/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2011, 3:39 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> This is the third-last commit from my branch :)
> 
> 
> Diffs
> -----
> 
>   engine/achievement.h 5d8403a 
>   engine/achievement.cpp 4a5e544 
>   engine/achievementsmanager.h 785226a 
>   engine/achievementsmanager.cpp ae95ddd 
> 
> Diff: http://git.reviewboard.kde.org/r/103249/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111126/7069bc44/attachment.html>