Review Request: Achievements 17: Sort the achievements

Felix Rohrbach fxrh at gmx.de
Sun Nov 20 18:36:11 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103186/
-----------------------------------------------------------

(Updated Nov. 20, 2011, 6:36 p.m.)


Review request for Gluon.


Changes
-------

I added some braces now, but I didn't use them in the "else if" statement, as I think nested if-else statements look confusing and over-complicated if written out. I think it can be read as the else-if statement many programming languages have.


Description
-------

.


Diffs (updated)
-----

  engine/achievementsmanager.cpp 8754a20 

Diff: http://git.reviewboard.kde.org/r/103186/diff/diff


Testing
-------


Thanks,

Felix Rohrbach

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111120/dc2778bb/attachment.html>


More information about the Gluon mailing list