Review Request: Achievements 16: Show dependency for locked achievements

[Arjen Hiemstra]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103184/#review8323
-----------------------------------------------------------

Ship it!


Nothing shocking in here.


engine/achievementsmanager.h
<http://git.reviewboard.kde.org/r/103184/#comment7115>

    Hmm, you might want to clarify that the two dependency methods deal with dependencies of specific achievements, i.e. dependency return the name of the achievement the achievement at index depends upon. Right now it took me some time before I understood the meaning of "dependency".


- Arjen Hiemstra


On Nov. 19, 2011, 1:36 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103184/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2011, 1:36 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> As the new delegate was postponed, this doesn't change anything visual, it only contains the code to be used by the delegate.
> 
> 
> Diffs
> -----
> 
>   engine/achievementsmanager.h 8787084 
>   engine/achievementsmanager.cpp 8754a20 
> 
> Diff: http://git.reviewboard.kde.org/r/103184/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111119/d092815c/attachment-0001.html>