Review Request: Achievements 17: Sort the achievements

[Arjen Hiemstra]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103186/#review8321
-----------------------------------------------------------

Ship it!


Something to look at later on would be to use a SortProxyModel for sorting the model instead of the list, it would make it possible to change sorting order and stuff like that. But that's for later.


engine/achievementsmanager.cpp
<http://git.reviewboard.kde.org/r/103186/#comment7113>

    Just a minor comment, I tend to prefer to use braces when there's more than two lines involved with an if statement, for example, when you have an else statement. It's not critical though, and I know there are several places around in the code that also use this style.


- Arjen Hiemstra


On Nov. 19, 2011, 3:12 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103186/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2011, 3:12 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   engine/achievementsmanager.cpp 8754a20 
> 
> Diff: http://git.reviewboard.kde.org/r/103186/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111119/94011f52/attachment.html>