Review Request: [Prefab 2/5] Engine: Buttons for PrefabInstance / PrefabInstanceChild

Dan Leinir Turthra Jensen admin at leinir.dk
Thu Nov 10 11:17:57 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103073/#review8090
-----------------------------------------------------------

Ship it!



creator/lib/widgets/prefabcontrols.cpp
<http://git.reviewboard.kde.org/r/103073/#comment6956>

    You'll probably want to include the local copy first (that is, use #include "" rather than #include <>, to avoid picking up the installed copy while you're working)


Since the above's just a minor comment, fix that and push :)

- Dan Leinir Turthra Jensen


On Nov. 7, 2011, 11:11 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103073/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2011, 11:11 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> Add a revert and a apply button to the properties view if the object inherits AbstractPrefabInstance.
> 
> 
> Diffs
> -----
> 
>   creator/lib/widgets/prefabcontrols.h 143992c 
>   creator/lib/widgets/prefabcontrols.cpp cbec61c 
>   creator/lib/widgets/propertywidgetcontainer.cpp 5b02bd4 
> 
> Diff: http://git.reviewboard.kde.org/r/103073/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111110/a2ede63c/attachment.html>


More information about the Gluon mailing list