Review Request: Achievements 15: A better UI for Achievements in the KDE Extended player.

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102987/#review7981
-----------------------------------------------------------


> As the title says. There will be more changes of the UI in later commits, so it wouldn't make much sense to discuss now about the look of the achievements tab in the player.

I would personally like to see the mocup of the imagined Ui before many patches coming. I would like to agree upon something before getting any new Ui in and code then to maintain (On the other hand, the whole Ui interface of this player should be redesigned by a person with relevant skills - for future reference).

- Laszlo Papp


On Nov. 4, 2011, 6:45 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102987/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2011, 6:45 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> As the title says. There will be more changes of the UI in later commits, so it wouldn't make much sense to discuss now about the look of the achievements tab in the player.
> 
> 
> Diffs
> -----
> 
>   engine/achievement.cpp 021ee24 
>   engine/achievementsmanager.h 1e9e24d 
>   engine/achievementsmanager.cpp e08a05d 
>   player/desktop/CMakeLists.txt 01cd3ee 
>   player/desktop/delegates/achievementdelegate.h PRE-CREATION 
>   player/desktop/delegates/achievementdelegate.cpp PRE-CREATION 
>   player/desktop/gamedetailsoverlay.h dd95f2a 
>   player/desktop/gamedetailsoverlay.cpp ca0d6a8 
>   player/lib/models/achievementsmodel.h c25c1f9 
>   player/lib/models/achievementsmodel.cpp 34000ff 
> 
> Diff: http://git.reviewboard.kde.org/r/102987/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111106/8fbb3394/attachment.html>