Review Request: Gluon build

[Anne-Marie Mahfouf]

> On March 27, 2011, 10:26 p.m., Laszlo Papp wrote:
> > Hi Anne-Marie !
> > 
> > > Make Gluon build for me. I am not sure the /player/CMakeLists.txt is the right way to do it.
> > 
> > Yes, that is the right way. I was refactoring the player build system during the sprint and it was quite a fragmented day to do it properly ... :)
> > I have fundamentally just copied the way from the creator which is also not that nice then, it seems so. I fixed those, thus I think your patch is fine with me. (also tested and does not have any regression on my side)
> > 
> > Note: include_directories(${LIBATTICA_INCLUDE_DIR}) addition will be removed later since I will place the attica related lines into the $projectroot/player/lib/CMakeLists.txt as far as it is possible, but it should be.
> > 
> > > For the player/lib/CMakeLists.txt patch, it makes it consistent with the other libs names and makes it build (the error I had was /usr/bin/ld:  cannot find -lGluonPlayer)
> > 
> > Can you tell me any scenario how to reproduce it, please ?
> > 
> > By the way, I was wondering during the kde games sprint about your commit in case the declarative fix. I mean it is really nice you are interested in this project, I have a full of nice feeling about it :p
> >

As you were in a sprint and changed a lot of the code, I am discarding this review. Nice to see Gluon doing so well!


- Anne-Marie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100956/#review2199
-----------------------------------------------------------


On March 27, 2011, 9:33 a.m., Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100956/
> -----------------------------------------------------------
> 
> (Updated March 27, 2011, 9:33 a.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Make Gluon build for me. I am not sure the /player/CMakeLists.txt is the right way to do it.
> For the player/lib/CMakeLists.txt patch, it makes it consistent with the other libs names and makes it build (the error I had was /usr/bin/ld: cannot find -lGluonPlayer)
> 
> 
> Diffs
> -----
> 
>   player/CMakeLists.txt 9c175f1 
>   player/lib/CMakeLists.txt adf35b1 
> 
> Diff: http://git.reviewboard.kde.org/r/100956/diff
> 
> 
> Testing
> -------
> 
> It now builds locally for me.
> 
> 
> Thanks,
> 
> Anne-Marie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110328/600ebb38/attachment.htm