Review Request: Move directory related code to DirectoryProvider singleton

[Arjen Hiemstra]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101727/#review4096
-----------------------------------------------------------

Ship it!


Looks good now. One last minor nitpick: You should probably rename userDir to userDirectory, makes for a nicer method name. :)

- Arjen


On June 23, 2011, 5:44 a.m., Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101727/
> -----------------------------------------------------------
> 
> (Updated June 23, 2011, 5:44 a.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> When we were adding userDir functions to GluonCore::Global, for caching and flexibility purposes it was needed to add two variables. Keeping these static was quite a mess, and I and Arjen concluded that a Singleton is more suited for this kind of stuff.
> As agreed on IRC, added a new class DirectoryProvider which has all the functions from GluonCore::Global except version because its not a directory function. Also, except the userDir function, other functions don't require an instance and can be called directly.
> 
> 
> Diffs
> -----
> 
>   core/CMakeLists.txt 8fd1dd0 
>   core/directoryprovider.h PRE-CREATION 
>   core/directoryprovider.cpp PRE-CREATION 
>   core/gluon_global.h.in 792d65e 
>   core/gluonobjectfactory.cpp 4501bed 
>   creator/plugins/docks/projectdock/projectdock.cpp e02ce53 
>   graphics/engine.cpp c4094b0 
>   graphics/examples/loadtexture/main.cpp 229f9a4 
>   player/kde/mainwindow.cpp 7071249 
>   player/lib/models/gameitemsmodel.cpp 63075ed 
>   player/lib/ocsprovider.cpp 1d5daa4 
>   player/qt/mainwindow.cpp 0470e33 
> 
> Diff: http://git.reviewboard.kde.org/r/101727/diff
> 
> 
> Testing
> -------
> 
> Overall Gluon's players seem to function properly. The userData function returns correct paths for me, request everyone to check once for their configuration.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110623/010487a9/attachment.htm