Review Request: Achievements 6: AchievementsManager

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102034/#review5125
-----------------------------------------------------------

Ship it!


I would probably use the order save/load or vica versa in the header file and inside the source file, like you did in case of the next patch. They are somewhat relevant things to each other, thus it makes sense if the "logical units" are as close to each other as possible (there is no alphabetical rule against it yet :). It is not a functionality remark, thus feel free to ignore, if you want to. The patch looks fine.

- Laszlo


On July 26, 2011, 5:48 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102034/
> -----------------------------------------------------------
> 
> (Updated July 26, 2011, 5:48 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> This class saves the achievements information into a separate file, so that achievements can be shown without opening the whole project.
> 
> 
> Diffs
> -----
> 
>   engine/CMakeLists.txt 59acf45 
>   engine/achievementsmanager.h PRE-CREATION 
>   engine/achievementsmanager.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102034/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110726/0ce04983/attachment.htm