Review Request: Achievements 7: ProjectMetaData

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102075/#review5049
-----------------------------------------------------------


I am not sure which name is preferred by the team, but any consistency is good as usual. You are using projectFooBar sometimes, and FooBar sometimes. According to your 6th patch (prior to this), achievements{Count,Path,Name,Achieved} was preferred. I am fine with both but mixed. 


engine/projectmetadata.h
<http://git.reviewboard.kde.org/r/102075/#comment4516>

    Mixed



engine/projectmetadata.h
<http://git.reviewboard.kde.org/r/102075/#comment4517>

    Mixed



engine/projectmetadata.cpp
<http://git.reviewboard.kde.org/r/102075/#comment4514>

    Mixed



engine/projectmetadata.cpp
<http://git.reviewboard.kde.org/r/102075/#comment4515>

    Mixed



engine/projectmetadata.cpp
<http://git.reviewboard.kde.org/r/102075/#comment4518>

    Mixed



engine/projectmetadata.cpp
<http://git.reviewboard.kde.org/r/102075/#comment4504>

    const QString like in other cases ?



engine/projectmetadata.cpp
<http://git.reviewboard.kde.org/r/102075/#comment4501>

    warning/debug message ?



engine/projectmetadata.cpp
<http://git.reviewboard.kde.org/r/102075/#comment4505>

    const QString ?


- Laszlo


On July 24, 2011, 4:59 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102075/
> -----------------------------------------------------------
> 
> (Updated July 24, 2011, 4:59 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> This class creates a file with some data about a project. With this, you can read some data about a project without the need to open it.
> 
> 
> Diffs
> -----
> 
>   engine/CMakeLists.txt 59acf45 
>   engine/projectmetadata.h PRE-CREATION 
>   engine/projectmetadata.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102075/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110724/05ea3c3f/attachment-0001.htm