Review Request: New project dialog: also check for changes in the name line edit
Laszlo Papp
lpapp at kde.org
Sun Jul 17 21:45:58 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101978/#review4775
-----------------------------------------------------------
Ship it!
- Laszlo
On July 17, 2011, 7:35 p.m., Felix Rohrbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101978/
> -----------------------------------------------------------
>
> (Updated July 17, 2011, 7:35 p.m.)
>
>
> Review request for Gluon.
>
>
> Summary
> -------
>
> When you first change the project directory in the project creation dialog and give it a name after that, the dialog doesn't recheck and says the project name would be empty. With this, the project is also validated when the project name is changed.
>
> Additionally I did two further minor things:
> 1. Remove the function urlEdited(). It just called validateData() and was only used in connection with the textEdited signal of the file directory edit widget.
> 2. Call validateData at the end of the constructor. At the moment, you can create a project with an empty name if you just click ok in the dialog before doing anything.
>
>
> Diffs
> -----
>
> creator/dialogs/newprojectdialogpage.h 3163dab
> creator/dialogs/newprojectdialogpage.cpp 562d5cd
>
> Diff: http://git.reviewboard.kde.org/r/101978/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Felix
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110717/88c1af73/attachment.htm
More information about the Gluon
mailing list