Review Request: New project dialog: also check for changes in the name line edit

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101978/#review4771
-----------------------------------------------------------



creator/dialogs/newprojectdialogpage.h
<http://git.reviewboard.kde.org/r/101978/#comment4155>

    Instead of the removal, please keep it and another slot for the name edit (like validateByProjectName().
    
    Please rename the urlEdited to validateByProjectLocation as well (make sure at every occurence). That name is a bit weird in case of a slot, but I think I inherited it from kdevelop.



creator/dialogs/newprojectdialogpage.cpp
<http://git.reviewboard.kde.org/r/101978/#comment4157>

    It would probably need another signal for the selection, but I have fixed that locally, no worries. :)



creator/dialogs/newprojectdialogpage.cpp
<http://git.reviewboard.kde.org/r/101978/#comment4156>

    Keep it and another slot as aforementioned. The reason is that we have a clean separation between actions. Originally, I wanted to emit a signal here (just like kdevelop does), but I apparently forgot it. Any action can be taken here which makes the location and name management different.


- Laszlo


On July 17, 2011, 4:58 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101978/
> -----------------------------------------------------------
> 
> (Updated July 17, 2011, 4:58 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> When you first change the project directory in the project creation dialog and give it a name after that, the dialog doesn't recheck and says the project name would be empty. With this, the project is also validated when the project name is changed.
> 
> Additionally I did two further minor things:
> 1. Remove the function urlEdited(). It just called validateData() and was only used in connection with the textEdited signal of the file directory edit widget.
> 2. Call validateData at the end of the constructor. At the moment, you can create a project with an empty name if you just click ok in the dialog before doing anything.
> 
> 
> Diffs
> -----
> 
>   creator/dialogs/newprojectdialogpage.h 3163dab 
>   creator/dialogs/newprojectdialogpage.cpp 562d5cd 
> 
> Diff: http://git.reviewboard.kde.org/r/101978/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110717/27479dd5/attachment-0001.htm