Review Request: Achievements 3: AchievementsAsset

[Felix Rohrbach]

> On July 12, 2011, 1:32 p.m., Arjen Hiemstra wrote:
> > engine/gluon_engine_export.h, lines 94-101
> > <http://git.reviewboard.kde.org/r/101909/diff/2/?file=26705#file26705line94>
> >
> >     While it is currently done this way in many assets/components it is not necessary to export them. As far as I know, the only reason we originally started exporting them was due to KDE's settings setting visibility("hidden") by default. This means we can avoid exporting them altogether which should not be done anyway. I have not seen any indication that this causes problems on windows either.

Laszlo seems to have some doubts about this working on windows, but he can't test it right now. Is it ok for you if I undo this change for this patch now and you / someone else can do this change on master for all assets later?


- Felix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101909/#review4645
-----------------------------------------------------------


On July 12, 2011, 2:30 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101909/
> -----------------------------------------------------------
> 
> (Updated July 12, 2011, 2:30 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Adds the AchievementsAsset class, which cares about the Achievement objects and saves them in a file. Also add mime-type information for this file type.
> 
> Note: This patch also adds the file "achievements_template.gluonachievements" at engine/assets/other/achievements/. As this file is empty, ReviewBoard doesn't show it.
> 
> 
> Diffs
> -----
> 
>   creator/x-gluon-mimetypes.xml 378876d 
>   engine/assets/CMakeLists.txt b8c087b 
>   engine/assets/other/achievements/CMakeLists.txt PRE-CREATION 
>   engine/assets/other/achievements/achievementsasset.h PRE-CREATION 
>   engine/assets/other/achievements/achievementsasset.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101909/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110717/c3a50356/attachment.htm