Review Request: Achievements 4: GameProject::achievements()

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101933/#review4718
-----------------------------------------------------------

Ship it!


My question is technically not possible to implement this way as we have just discussed on IRC. Seems the QList wants to store pointers to non-const Achievements, so you would need to either change that to QList<const Achievement*> , or pass in pointers to non-const Ahievements. I am sorry for the question, it is the best how it is now.

I am fine with it since the really important change happened as asked for.

- Laszlo


On July 13, 2011, 6:28 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101933/
> -----------------------------------------------------------
> 
> (Updated July 13, 2011, 6:28 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Create a function that returns a list of all achievements of a GameProject.
> 
> 
> Diffs
> -----
> 
>   engine/achievement.h 79337b1 
>   engine/achievement.cpp 53a6917 
>   engine/assets/other/achievements/achievementsasset.cpp PRE-CREATION 
>   engine/gameproject.h 805d193 
>   engine/gameproject.cpp 8d84024 
>   engine/gameprojectprivate.h 38c442a 
>   engine/gameprojectprivate.cpp 08424b1 
> 
> Diff: http://git.reviewboard.kde.org/r/101933/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110713/31301b53/attachment.htm