Review Request: Achievements 2: LongLongPropertyWidgetItem
Felix Rohrbach
fxrh at gmx.de
Tue Jul 12 17:25:36 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101908/
-----------------------------------------------------------
(Updated July 12, 2011, 3:25 p.m.)
Review request for Gluon.
Changes
-------
1. Mark two slots virtual, as they are reimplemented virtual slots
2. Added a check for the doubleValueChanged. I didn't made it private, because the other PropertyWidgetItems don't do, too.
Summary
-------
Add a PropertyWidgetItem to edit qlonglong values in the creator. Needed by the Achievement class.
Diffs (updated)
-----
creator/plugins/docks/propertiesdock/CMakeLists.txt 05c5242
creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.h PRE-CREATION
creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/101908/diff
Testing
-------
Tested with the Achievement and Statistic class. When the value is out of the limit, it is set to 0.
Thanks,
Felix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110712/d4ca7ac8/attachment.htm
More information about the Gluon
mailing list