Review Request: Achievements 2: LongLongPropertyWidgetItem
Arjen Hiemstra
djfreestyler at gmail.com
Tue Jul 12 15:11:49 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101908/#review4644
-----------------------------------------------------------
creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp
<http://git.reviewboard.kde.org/r/101908/#comment4076>
If you are using a double validator anyway, why not simply use a DoubleSpinBox with decimals set to 0?
Right now I need to enter a number by hand, whereas using a spinbox I can just use the scrollwheel to change value, something I actually do very often.
- Arjen
On July 11, 2011, 1:15 p.m., Felix Rohrbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101908/
> -----------------------------------------------------------
>
> (Updated July 11, 2011, 1:15 p.m.)
>
>
> Review request for Gluon.
>
>
> Summary
> -------
>
> Add a PropertyWidgetItem to edit qlonglong values in the creator. Needed by the Achievement class.
>
>
> Diffs
> -----
>
> creator/plugins/docks/propertiesdock/CMakeLists.txt 05c5242
> creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.h PRE-CREATION
> creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/101908/diff
>
>
> Testing
> -------
>
> Tested with the Achievement and Statistic class. When the value is out of the limit, it is set to 0.
>
>
> Thanks,
>
> Felix
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110712/3eb78fc5/attachment.htm
More information about the Gluon
mailing list